You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/30 13:02:03 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4470: Append Row to Rows (#4466)

tustvold commented on code in PR #4470:
URL: https://github.com/apache/arrow-rs/pull/4470#discussion_r1247838171


##########
arrow-row/src/lib.rs:
##########
@@ -832,14 +871,25 @@ struct RowConfig {
 #[derive(Debug)]
 pub struct Rows {
     /// Underlying row bytes
-    buffer: Box<[u8]>,
+    buffer: Vec<u8>,

Review Comment:
   I need to double-check this doesn't result in a performance regression, it shouldn't but stranger things have happened



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org