You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/03/13 19:47:21 UTC

[GitHub] [accumulo] keith-turner opened a new issue #1031: Tablet lock acquired very frequently during compaction.

keith-turner opened a new issue #1031: Tablet lock acquired very frequently during compaction.
URL: https://github.com/apache/accumulo/issues/1031
 
 
   I think the tablet lock is acquired and released very frequently during compaction, like for each key/value written.
   
   The code below is the compaction loop and it calls env.isCompactionEnabled()
   
   https://github.com/apache/accumulo/blob/rel/1.9.2/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java#L379
   
   Below is impl for compaction env and it calls Tablet.isCompactionEnabled
   
   https://github.com/apache/accumulo/blob/rel/1.9.2/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L1981
   
   Below is Tablet.isCompactionEnabled which calls isClosed
   
   https://github.com/apache/accumulo/blob/rel/1.9.2/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L1794
   
   Below is Tablet.isClosed which is synchronized.
   
   https://github.com/apache/accumulo/blob/rel/1.9.2/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L2209
   
   Possible fixes are to use a volatile or check less frequently like every 1/1000 calls to isCompactoinEnabled.  Volatile would be better so that compactions don't wait on unrelated tablet operations.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services