You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/10/02 07:53:16 UTC

[GitHub] [libcloud] Matir opened a new pull request #1498: Support GCE instances with no service accounts

Matir opened a new pull request #1498:
URL: https://github.com/apache/libcloud/pull/1498


   ## Support GCE instances with no service accounts
   
   ### Description
   
   This fixes #1497.  When an empty list (`[]`) is passed in for ex_service_accounts,
   a VM with no service accounts is created.  When None is passed in (the default),
   the behavior remains unchanged, giving the default service account.
   
   ### Status
   
   done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1498: Support GCE instances with no service accounts

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1498:
URL: https://github.com/apache/libcloud/pull/1498#issuecomment-703267448


   LGTM, thanks for the contribution.
   
   It would be good to add some test cases though :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1498: Support GCE instances with no service accounts

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1498:
URL: https://github.com/apache/libcloud/pull/1498#issuecomment-703285728


   I've added a test case (0eb48647e520ed61fa5f473f3b540be9885c3861, 0616c2e8b99736a63d1bee9c5bb4cbd602373712) and merged changes into trunk.
   
   Thanks again for your contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] asfgit merged pull request #1498: Support GCE instances with no service accounts

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1498:
URL: https://github.com/apache/libcloud/pull/1498


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org