You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/07 07:06:49 UTC

[GitHub] [spark] wangyum commented on a change in pull request #26788: [SPARK-30159][SQL][TESTS] Fix the method calls of `QueryTest.checkAnswer`

wangyum commented on a change in pull request #26788: [SPARK-30159][SQL][TESTS] Fix the method calls of `QueryTest.checkAnswer`
URL: https://github.com/apache/spark/pull/26788#discussion_r355105327
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala
 ##########
 @@ -755,7 +755,7 @@ class StreamSuite extends StreamTest {
         inputData.addData(9)
         streamingQuery.processAllAvailable()
 
-        QueryTest.checkAnswer(spark.table("counts").toDF(),
+        checkAnswer(spark.table("counts").toDF(),
           Row("1", 1) :: Row("2", 1) :: Row("3", 2) :: Row("4", 2) ::
           Row("5", 2) :: Row("6", 2) :: Row("7", 1) :: Row("8", 1) :: Row("9", 1) :: Nil)
 
 Review comment:
   This should fail because the types do not match: https://github.com/apache/spark/pull/26768/files#r354499485

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org