[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3795: Timezone aware timestamp parsing (#3794)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3795:
URL: https://github.com/apache/arrow-rs/pull/3795#discussion_r1124369319


##########
arrow-cast/src/parse.rs:
##########
@@ -614,6 +629,19 @@ mod tests {
             naive_datetime.timestamp_nanos(),
             parse_timestamp("2020-09-08 13:42:29").unwrap()
         );
+
+        let tz: Tz = "+02:00".parse().unwrap();
+        let date = string_to_datetime(&tz, "2020-09-08 13:42:29").unwrap();
+        let utc = date.naive_utc().to_string();
+        assert_eq!(utc, "2020-09-08 11:42:29");
+        let local = date.naive_local().to_string();
+        assert_eq!(local, "2020-09-08 13:42:29");
+
+        let date = string_to_datetime(&tz, "2020-09-08 13:42:29Z").unwrap();
+        let utc = date.naive_utc().to_string();
+        assert_eq!(utc, "2020-09-08 13:42:29");
+        let local = date.naive_local().to_string();
+        assert_eq!(local, "2020-09-08 15:42:29");

Review Comment:
   I wanted to avoid using `Local::now` in the tests as this makes the tests not reproducible. The tests above should cover this, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org