Re: Review Request 28509: SENTRY-485: Add test coverage for auditing in E2E, secure environment

[Colin Ma <ju...@intel.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28509/
-----------------------------------------------------------

(Updated Dec. 1, 2014, 4:43 a.m.)


Review request for sentry.


Repository: sentry


Description
-------

Currently, we don't test results of audit logs in an E2E, secure environment. There was a bug in this area (SENTRY-484) and we should improve the test coverage to ensure there are no regressions in the future. Currently, it is a bit hard to test E2E and it will require a few modifications to the test environment to enable this testing.
As part of this change, we should also add a regression test for SENTRY-484.


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 90308f4 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 9beef83 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryProcessorWrapper.java 6f3508d 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ThriftUtil.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java bce4717 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestAuthorizingDDLAuditLogWithKerberos.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 2cecdfd 

Diff: https://reviews.apache.org/r/28509/diff/


Testing
-------


Thanks,

Colin Ma