You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/26 01:24:59 UTC
[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new pull
request #1582: api/common/ParameterUtils Utils Test
xingchun-chen opened a new pull request #1582: api/common/ParameterUtils Utils Test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1582
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1582:
api/common/ParameterUtils Utils Test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1582: api/common/ParameterUtils Utils Test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1582#issuecomment-568945196
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=h1) Report
> Merging [#1582](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1582 +/- ##
========================================
+ Coverage 7.58% 8.42% +0.83%
========================================
Files 277 277
Lines 13743 13743
Branches 2194 2194
========================================
+ Hits 1043 1158 +115
+ Misses 12631 12498 -133
- Partials 69 87 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...common/utils/placeholder/TimePlaceholderUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL1RpbWVQbGFjZWhvbGRlclV0aWxzLmphdmE=) | `2.59% <0%> (+2.59%)` | :arrow_up: |
| [...n/utils/placeholder/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL1Byb3BlcnR5UGxhY2Vob2xkZXJIZWxwZXIuamF2YQ==) | `54.43% <0%> (+54.43%)` | :arrow_up: |
| [...ler/common/utils/placeholder/PlaceholderUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL1BsYWNlaG9sZGVyVXRpbHMuamF2YQ==) | `54.54% <0%> (+54.54%)` | :arrow_up: |
| [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `58.46% <0%> (+58.46%)` | :arrow_up: |
| [...er/common/utils/placeholder/BusinessTimeUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL0J1c2luZXNzVGltZVV0aWxzLmphdmE=) | `91.66% <0%> (+91.66%)` | :arrow_up: |
| [...che/dolphinscheduler/common/enums/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0NvbW1hbmRUeXBlLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=footer). Last update [026fdd9...09111f3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen closed pull request
#1582: api/common/ParameterUtils Utils Test
Posted by GitBox <gi...@apache.org>.
xingchun-chen closed pull request #1582: api/common/ParameterUtils Utils Test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services