You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2021/07/28 20:18:00 UTC

[jira] [Closed] (DAFFODIL-2252) Custom GitHub action to check pull requests with more than one commit

     [ https://issues.apache.org/jira/browse/DAFFODIL-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2252.
-----------------------------------

Verified the specified commit (commit 85fc372a66f9393002692c2655697e5907dec9c6) is included in the latest pull from the daffodil repository.

Verified by review, changes identified in commit comment were implemented.

> Custom GitHub action to check pull requests with more than one commit
> ---------------------------------------------------------------------
>
>                 Key: DAFFODIL-2252
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2252
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Steve Lawrence
>            Assignee: Steve Lawrence
>            Priority: Minor
>              Labels: beginner
>             Fix For: 3.2.0
>
>
> Often times we add multiple fixup commits to a pull request based on review comments, but forget to squash before merging. This leads to a slightly messier commit history where a single commit doesn't show the full story of what chnaged.
> To avoid this, we should add a custom GithubActions check that determines the number of commits in a pull request and either shows a check failure, or disalllows merging completely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)