You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by wa...@apache.org on 2022/10/13 01:40:46 UTC
[pulsar] branch dave2wave-patch-3 created (now 1eeb8ef1fb4)
This is an automated email from the ASF dual-hosted git repository.
wave pushed a change to branch dave2wave-patch-3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
at 1eeb8ef1fb4 [improve][misc] Highlight change to threading
This branch includes the following new commits:
new 1eeb8ef1fb4 [improve][misc] Highlight change to threading
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[pulsar] 01/01: [improve][misc] Highlight change to threading
Posted by wa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wave pushed a commit to branch dave2wave-patch-3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 1eeb8ef1fb49b5f678435e4fe1f704c5edb577a8
Author: Dave Fisher <da...@comcast.net>
AuthorDate: Wed Oct 12 18:40:40 2022 -0700
[improve][misc] Highlight change to threading
Whenever a PR changes the threading model we need to make clear that we should track these changes
---
.github/PULL_REQUEST_TEMPLATE.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 1b984758380..b6ef48bda60 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -56,6 +56,7 @@ This change added tests and can be verified as follows:
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
+- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
@@ -83,6 +84,6 @@ apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
-The tests will be run in the forked repository until all PR review comments have
+The tests will be run in the forkedrepository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->