You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/09 03:03:55 UTC
[GitHub] [openwhisk-wskdeploy] jbampton opened a new pull request #1127: chore: fix spelling
jbampton opened a new pull request #1127:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1127: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1127:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1127#issuecomment-800405753
@jbampton Thanks for such a comprehensive cleanup of all our code/docs! If you could run the go-bindata tool as ref. in the review (https://github.com/apache/openwhisk-wskdeploy/blob/master/wski18n/README.md) and commit the resultant `i18n_resources.go` file, I would love to merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1127: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #1127:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1127: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1127:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1127#discussion_r595326915
##########
File path: wski18n/resources/en_US.all.json
##########
@@ -21,7 +21,7 @@
},
{
"id": "msg_cmd_desc_long_root",
- "translation": "The OpenWhisk Deployment Tool\n\nTo begin working with wskdeploy, run the 'wskdeploy' command:\n\n\t$ wskdeploy\n\nThis will deploy OpenWhisk assets specified in manifest.yaml or manifest.yml\nIf current directory doesnt have any manifest file, wskdeploy prints this help message.\n\nThe most common ways of using wskdeploy to deploy and/or undeploy OpenWhisk assets are:\n\n$ wskdeploy\n$ wskdeploy -m path/to/manifest.yaml\n$ wskdeploy -m path/to/manifest.yaml -d path/to/deployment.yaml\n$ wskdeploy undeploy\n$ wskdeploy undeploy -m path/to/manifest.yaml\n$ wskdeploy undeploy -m path/to/manifest.yaml -d path/to/deployment.yaml\n\nAunthentication:\nwskdeploy reads credentials from $HOME/.wskprops by default\nOverwrite default config file on CLI:\n $ wskdeploy --config <config file> -m path/to/manifest.yaml\nOr specify all three on CLI:\n $ wskdeploy --apihost HOST --auth KEY --namespace NAMESPACE -m path/to/manifest.yaml"
Review comment:
These changes need to be "built" using the go-bindata tool to render them as ascii-encoded data using the following instructions: https://github.com/apache/openwhisk-wskdeploy/blob/master/wski18n/README.md
##########
File path: docs/wskdeploy_apigateway_http.md
##########
@@ -87,9 +87,9 @@ Because a HTTP response disables the API Gateway default handling, you have to p
- a `body` field that contains your normal payload,
- an optional `headers` field that includes any HTTP header you want to set, typically `Content-Type`.
-If you don't provide this structure, the API Gateway will generate a HTTP response with status code `204: No Content` and an empty body. If this occurs when it shouldn't, it's probably a sign that you have a HTTP response specified with the gateway but the undelying action doesn't return this structure.
+If you don't provide this structure, the API Gateway will generate a HTTP response with status code `204: No Content` and an empty body. If this occurs when it shouldn't, it's probably a sign that you have a HTTP response specified with the gateway but the underlying action doesn't return this structure.
-When you want to return an error, you need to provide the same structure wrapped into an `error` object. If you don't wrap it into an `error` object, it will still work from an HTTP prespective but OpenWhisk will not recognise it as an error.
Review comment:
Another typo common to me...
##########
File path: utils/zip.go
##########
@@ -31,8 +31,8 @@ import (
const PATH_WILDCARD = "*"
const ONE_DIR_UP = "../"
-func NewZipWritter(src string, des string, include [][]string, exclude []string, manifestFilePath string) *ZipWritter {
Review comment:
This has long bothered me; thanks for fixing and cascading
##########
File path: deployers/deploymentreader_test.go
##########
@@ -95,7 +95,7 @@ func testLoadAndBindDeploymentYAML(t *testing.T, path string, triggerName string
dReader := NewDeploymentReader(sDeployer)
err := dReader.HandleYaml()
- // DEBUG() Uncomment to display initial DeploymentDescriptor (manifest, deployemnt befopre binding)
Review comment:
Always type this wrong ;) Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org