[GitHub] [incubator-doris] stdpain commented on a change in pull request #5684: [refactor] Remove boost mutex, use std::mutex instead

[GitBox <gi...@apache.org>]

stdpain commented on a change in pull request #5684:
URL: https://github.com/apache/incubator-doris/pull/5684#discussion_r616401120



##########
File path: be/src/runtime/data_stream_recvr.cc
##########
@@ -19,8 +19,8 @@
 
 #include <google/protobuf/stubs/common.h>
 
-#include <boost/thread/locks.hpp>
-#include <boost/thread/mutex.hpp>
+

Review comment:
       code format here

##########
File path: be/src/common/object_pool.h
##########
@@ -18,8 +18,8 @@
 #ifndef DORIS_BE_SRC_COMMON_COMMON_OBJECT_POOL_H
 #define DORIS_BE_SRC_COMMON_COMMON_OBJECT_POOL_H
 
-#include <boost/thread/locks.hpp>
-#include <boost/thread/mutex.hpp>
+

Review comment:
       code format here ?

##########
File path: be/src/runtime/thread_resource_mgr.h
##########
@@ -23,7 +23,7 @@
 #include <boost/function.hpp>
 #include <boost/scoped_ptr.hpp>
 #include <boost/shared_ptr.hpp>
-#include <boost/thread/mutex.hpp>
+#include <mutex>

Review comment:
       adjust include file order ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org