You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/31 01:59:49 UTC

[GitHub] TaoLv commented on a change in pull request #12953: Update MKL-DNN dependency

TaoLv commented on a change in pull request #12953: Update MKL-DNN dependency
URL: https://github.com/apache/incubator-mxnet/pull/12953#discussion_r229543503
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -239,8 +239,11 @@ if(USE_MKLDNN)
   if(NOT MSVC)
     set(ARCH_OPT_FLAGS "-mtune=generic")
   endif()
-  set(WITH_TEST OFF)
-  set(WITH_EXAMPLE OFF)
+  set(WITH_TEST OFF CACHE INTERNAL "" FORCE)
+  set(WITH_EXAMPLE OFF CACHE INTERNAL "" FORCE)
+  set(ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
+
+  include_directories(3rdparty/mkldnn)
 
 Review comment:
   Some headers in `src/common` are used for MKL-DNN tests. Previously, `set(WITH_TEST OFF)` doesn't work for MKL-DNN build. Those MKL-DNN tests will still be compiled. I change the setting for `WITH_TEST` and `WITH_EXAMPLE` here, so maybe this line can be removed. I will try.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services