You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:32:39 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #15670: Improve GC logging parameters

lhotari commented on code in PR #15670:
URL: https://github.com/apache/pulsar/pull/15670#discussion_r889894929


##########
bin/pulsar:
##########
@@ -48,6 +52,8 @@ PRESTO_HOME=${PULSAR_HOME}/lib/presto
 # Check bookkeeper env and load bkenv.sh
 if [ -f "$PULSAR_HOME/conf/bkenv.sh" ]
 then
+    BOOKIE_LOG_DIR=${BOOKIE_LOG_DIR:-"${PULSAR_LOG_DIR}"}

Review Comment:
   I disagree on your observation since pulsar-daemon.sh is not used in all cases. I have pushed a comment to also handle pulsar-daemon.sh and make it consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org