[GitHub] [pulsar] merlimat commented on a change in pull request #4768: Expose acknowledgment flushing capabilities at the consumer level

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4768: Expose acknowledgment flushing capabilities at the consumer level
URL: https://github.com/apache/pulsar/pull/4768#discussion_r305646277
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
 ##########
 @@ -255,6 +255,13 @@
      * @return a future that can be used to track the completion of the operation
      */
     CompletableFuture<Void> acknowledgeCumulativeAsync(MessageId messageId);
+    
+    /**
+     * Flush all batched acknowledgements and wait until all acknowledgments have been persisted.
+     * 
+     * Flush acks returns immediately if batching of acks is disabled.
+     */
+    void flushAcknowledgements();
 
 Review comment:
   Since there's no "ack on the ack", the sync vs async won't matter much. We had it initially on the acknowledge, though that was never a great idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services