[GitHub] wu-sheng commented on a change in pull request #2075: Refactor register API for making integration easier.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2075: Refactor register API for making integration easier.
URL: https://github.com/apache/incubator-skywalking/pull/2075#discussion_r243490703
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2RegisterDAO.java
 ##########
 @@ -46,15 +46,16 @@ public H2RegisterDAO(JDBCHikariCPClient h2Client,
         this.storageBuilder = storageBuilder;
     }
 
-    @Override public int max(String modelName) throws IOException {
+    @Override public int registerId(String modelName,
+        RegisterSource registerSource) throws IOException {
         try (Connection connection = h2Client.getConnection()) {
-            try (ResultSet rs = h2Client.executeQuery(connection, "SELECT max(sequence) max_id FROM " + modelName)) {
+            try (ResultSet rs = h2Client.executeQuery(connection, "SELECT registerId(sequence) max_id FROM " + modelName)) {
 
 Review comment:
   Yes. I will fix this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services