[GitHub] [superset] yzliao-zip commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated

[GitBox <gi...@apache.org>]

yzliao-zip commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r838058351



##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -90,14 +90,22 @@ WTF_CSRF_EXEMPT_LIST = []
 # A CSRF token that expires in 1 year
 WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
 class CeleryConfig(object):
-  BROKER_URL = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
   CELERY_IMPORTS = ('superset.sql_lab', )
-  CELERY_RESULT_BACKEND = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
   CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
+{{- if .Values.supersetNode.connections.redis_password }}

Review comment:
       I think the check of `auth.enabled` is needed here. Otherwise, the redis without password is connected with an incorrect url because the default value in `value.yaml` is set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org