You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/03 06:09:18 UTC
[kudu-CR] create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14358
to review the following change.
Change subject: create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
......................................................................
create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
The last check in this test only had 10s to complete, which isn't enough in
TSAN builds due to KUDU-2963. Let's replace it with an ASSERT_EVENTUALLY
which, besides being cleaner, also gives it more time to finish.
Change-Id: I37da7ea12f5432b947200fe8f08540e7b1ecbcec
---
M src/kudu/integration-tests/create-table-itest.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/14358/1
--
To view, visit http://gerrit.cloudera.org:8080/14358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37da7ea12f5432b947200fe8f08540e7b1ecbcec
Gerrit-Change-Number: 14358
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14358 )
Change subject: create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37da7ea12f5432b947200fe8f08540e7b1ecbcec
Gerrit-Change-Number: 14358
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Oct 2019 15:43:50 +0000
Gerrit-HasComments: No
[kudu-CR] create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14358 )
Change subject: create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
......................................................................
create-table-itest: deflake TestCreateWhenMajorityOfReplicasFailCreation
The last check in this test only had 10s to complete, which isn't enough in
TSAN builds due to KUDU-2963. Let's replace it with an ASSERT_EVENTUALLY
which, besides being cleaner, also gives it more time to finish.
Change-Id: I37da7ea12f5432b947200fe8f08540e7b1ecbcec
Reviewed-on: http://gerrit.cloudera.org:8080/14358
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/create-table-itest.cc
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37da7ea12f5432b947200fe8f08540e7b1ecbcec
Gerrit-Change-Number: 14358
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)