You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "3424672656 (via GitHub)" <gi...@apache.org> on 2026/07/22 06:41:11 UTC
[I] [Feature] Completely remove the dependency of fastjson1 [rocketmq]
3424672656 opened a new issue, #10646:
URL: https://github.com/apache/rocketmq/issues/10646
### Is Your Feature Request Related to a Problem?
Completely remove the dependency of fastjson1
### Describe the Solution You'd Like
Completely remove the dependency of fastjson1
### Describe Alternatives You've Considered
Completely remove the dependency of fastjson1
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Completely remove the dependency of fastjson1 [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10646:
URL: https://github.com/apache/rocketmq/issues/10646#issuecomment-5042908336
**Issue Evaluation**
Category: `type/enhancement` | Status: **Evaluated**
**Feasibility:** Feasible — the fastjson1 dependency is nearly fully removed already.
**Current fastjson1 footprint (on `develop` branch):**
| Location | Usage |
|----------|-------|
| `pom.xml` (L694) | Dependency management entry (`com.alibaba:fastjson:1.2.83`) |
| `common/pom.xml` (L37) | Direct dependency declaration |
| `remoting/src/test/.../RemotingSerializableCompatTest.java` (L20, L279, L411) | Compatibility test: serializes with fastjson1, deserializes with fastjson2 to verify backward compatibility |
**Scope:** Very small. Only **1 test file** and **2 pom.xml entries** remain.
**Key consideration:** The remaining Java usage is in `RemotingSerializableCompatTest`, which is a **fastjson1↔fastjson2 backward-compatibility test**. It intentionally uses `com.alibaba.fastjson.JSON.toJSONString()` to verify that objects serialized by fastjson1 can be correctly deserialized by fastjson2. The `@JSONField` annotation from fastjson1 is also used to check field-level serialize control.
**Suggested approach:**
1. Decide whether the fastjson1↔fastjson2 compatibility test is still needed (fastjson2 has been the default serializer for a while now)
2. If the compat test is no longer needed: remove the test, then remove the dependency from both `pom.xml` files
3. If the compat test is still desired: consider alternative approaches (e.g., keeping pre-serialized JSON strings as test fixtures instead of depending on fastjson1 at runtime)
This is a maintainers' decision — the technical work itself is trivial.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org