[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5152: [TE][subscription] update subscription watermarks to use anomaly create time instead of end time

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #5152: [TE][subscription] update subscription watermarks to use anomaly create time instead of end time
URL: https://github.com/apache/incubator-pinot/pull/5152#discussion_r393910889
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/SubscriptionConfigValidator.java
 ##########
 @@ -90,10 +90,6 @@ public void validateConfig(DetectionAlertConfigDTO alertConfig) throws IllegalAr
    */
   @Override
   public void validateYaml(Map<String, Object> config) throws IllegalArgumentException {
-    // Make sure recipients are configured at the right place
-    Preconditions.checkArgument(!config.containsKey(PROP_RECIPIENTS),
 
 Review comment:
   That's already remove in another PR and merged. I need to rebase the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org