You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@creadur.apache.org by po...@apache.org on 2022/03/28 12:47:48 UTC
[creadur-rat] branch fix/RAT-273 created (now 709473c)
This is an automated email from the ASF dual-hosted git repository.
pottlinger pushed a change to branch fix/RAT-273
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git.
at 709473c RAT-273: Change build matrix on ASF to work with latest LTS
This branch includes the following new commits:
new 0ab88c3 RAT-273: Adapt test expectations to newer JDK's behaviour
new 600ead8 RAT-273: Change build matrix to work with LTS and newest JDK
new 8f4bb0b RAT-273: Change build matrix to work with LTS and newest JDK
new 709473c RAT-273: Change build matrix on ASF to work with latest LTS
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[creadur-rat] 03/04: RAT-273: Change build matrix to work with LTS and newest JDK
Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pottlinger pushed a commit to branch fix/RAT-273
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit 8f4bb0bc24b70dc0a6a9f6de02458ae80601642b
Author: P. Ottlinger <po...@apache.org>
AuthorDate: Mon Mar 28 14:44:27 2022 +0200
RAT-273: Change build matrix to work with LTS and newest JDK
---
.github/workflows/maven.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 2760775..1d65baa 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -31,7 +31,7 @@ jobs:
os: [ubuntu-latest, windows-latest]
# RAT-296: disable JDK10 due to
# Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
- java: [8, 11, 12, 13, 14, 15]
+ java: [8, 11, 17, 18]
fail-fast: false
runs-on: ${{ matrix.os }}
[creadur-rat] 01/04: RAT-273: Adapt test expectations to newer JDK's behaviour
Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pottlinger pushed a commit to branch fix/RAT-273
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit 0ab88c3758637ea53ff3c3e8808de374cdb39ffd
Author: P. Ottlinger <po...@apache.org>
AuthorDate: Mon Mar 28 14:40:03 2022 +0200
RAT-273: Adapt test expectations to newer JDK's behaviour
---
.../org/apache/rat/header/HeaderMatcherTest.java | 32 ++++++++++++++++------
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java b/apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java
index 721fa06..0287461 100644
--- a/apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java
+++ b/apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java
@@ -67,22 +67,38 @@ public class HeaderMatcherTest {
@Test
public void noLines() throws Exception {
- StringReader reader = new StringReader("None");
+ StringReader reader = new StringReader("");
matcher.read(reader);
assertEquals("No lines read", 0, matcher.lines());
}
-
+
@Test
- public void lines() throws Exception {
- StringReader reader = new StringReader("One\n");
+ public void noLines_lineEndingHandledDifferentlyInNewerJDK() throws Exception {
+ StringReader reader = new StringReader("None");
matcher.read(reader);
- assertEquals("One line read", 1, matcher.lines());
- reader = new StringReader("One\nTwo");
+ int numberOfLinesRead = matcher.lines();
+ assertTrue("No lines read in older JDK or one line in newer JDK as implicit stream end is counted as line ending", numberOfLinesRead == 0 || numberOfLinesRead == 1);
+ }
+
+ @Test
+ public void lines_lineEndingHandledDifferentlyInNewerJDK() throws Exception {
+ StringReader reader = new StringReader("One\nTwo");
matcher.read(reader);
- assertEquals("One line read", 1, matcher.lines());
+ int numberOfLinesRead = matcher.lines();
+ assertTrue("One line read read in older JDK or two lines in newer JDK as implicit stream end is counted as line ending", numberOfLinesRead == 1 || numberOfLinesRead == 2);
+
reader = new StringReader("One\nTwo\nThree");
matcher.read(reader);
- assertEquals("Two lines read", 2, matcher.lines());
+ numberOfLinesRead = matcher.lines();
+ assertTrue("Two lines read read in older JDK or three lines in newer JDK as implicit stream end is counted as line ending", numberOfLinesRead == 2 || numberOfLinesRead == 3);
+ }
+
+ @Test
+ public void lines() throws Exception {
+ StringReader reader = new StringReader("One\n");
+ matcher.read(reader);
+ assertEquals("One line read", 1, matcher.lines());
+
reader = new StringReader("One\nTwo\nThree\n");
matcher.read(reader);
assertEquals("Three lines read", 3, matcher.lines());
[creadur-rat] 04/04: RAT-273: Change build matrix on ASF to work with latest LTS
Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pottlinger pushed a commit to branch fix/RAT-273
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit 709473cf481dc25c7672cc05a8984982628b326d
Author: P. Ottlinger <po...@apache.org>
AuthorDate: Mon Mar 28 14:45:46 2022 +0200
RAT-273: Change build matrix on ASF to work with latest LTS
---
Jenkinsfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Jenkinsfile b/Jenkinsfile
index 6839e75..7511296 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -41,7 +41,7 @@ pipeline {
tools {
maven 'maven_3_latest'
- jdk 'jdk_14_latest'
+ jdk 'jdk_17_latest'
}
options {
[creadur-rat] 02/04: RAT-273: Change build matrix to work with LTS and newest JDK
Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pottlinger pushed a commit to branch fix/RAT-273
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit 600ead863f481d1130fcd38e7ec83203816206f6
Author: P. Ottlinger <po...@apache.org>
AuthorDate: Mon Mar 28 14:43:23 2022 +0200
RAT-273: Change build matrix to work with LTS and newest JDK
---
.travis.yml | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 332292a..ea4539c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,6 +8,14 @@ jobs:
jdk: openjdk8
script: mvn -e -B -V clean package site
- - name: "Java 14"
- jdk: openjdk14
+ - name: "Java 11"
+ jdk: openjdk11
+ script: mvn -e -B -V clean package site
+
+ - name: "Java 17"
+ jdk: openjdk17
+ script: mvn -e -B -V clean package site
+
+ - name: "Java 18 - newest"
+ jdk: openjdk18
script: mvn -e -B -V clean package site