[jira] Commented: (TAPESTRY-1000) XTileService should call cycle.active(page)

["Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>]

    [ http://issues.apache.org/jira/browse/TAPESTRY-1000?page=comments#action_12419158 ] 

Andreas Andreou commented on TAPESTRY-1000:
-------------------------------------------

I don't like this.

In my mind, XTileService is a very lightweight service that simply calls a method in the server.
It is not like any other services (direct, page). It does NOT activate a page, nor does it call 
pageBeginRender() on a page class.

I believe this was the intended behaviour, i.e. allow simple, DWR-style requests.

This means that the listeners used with XTile should be independent of the page they are in.
I consider them something like 'static' methods. 

I think that the correct use-case for XTile would be to call Hivemind services instead of 
Tapestry page listeners. If this was the default scenario, there wouldn't be a lot of 
misunderstandings regarding this service...




> XTileService should call cycle.active(page)
> -------------------------------------------
>
>          Key: TAPESTRY-1000
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-1000
>      Project: Tapestry
>         Type: Bug

>   Components: Contrib
>     Versions: 4.0.2
>     Reporter: Paul Field

>
> The service() method of org.apache.tapestry.contrib.ajax.XTileService should call
>      cycle.activate(componentPage);
> before it calls:
>     xtile.trigger(cycle);
> Without this call (i.e. the current situation):
>   * Users might be able to access a page on which page.validate() fails.
>   * Components that rely on requestCycle.getPage() (for example the DirectLink) will generate a NullPointerException when rendered by the XTileService.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org