You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/05 12:01:16 UTC

[GitHub] [shardingsphere] terrymanu commented on issue #5421: The keyGenerator doesn't work in transaction-2pc-xa-raw-jdbc-example module when a oracle database used

terrymanu commented on issue #5421:
URL: https://github.com/apache/shardingsphere/issues/5421#issuecomment-624013196


   Some suggestions:
   1. We need to make sure about oracle SQL and semicolon.
   2. If return true for ResultSet.next() with connection.getMetaData().getIndexInfo(), what's happen for null value of `resultSet.getString(INDEX_NAME)`?
   3. The 3rd modification is OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org