You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/03/24 21:50:57 UTC

[GitHub] [helix] NealSun96 opened a new issue #1682: SharedZkClientFactory.buildZkClient (for HelixClient) does not respect ClientConfig settings

NealSun96 opened a new issue #1682:
URL: https://github.com/apache/helix/issues/1682


   ### Describe the bug
   The `SharedZkClientFactory.buildZkClient` function that returns a `HelixClient` does not respect the ClientConfig settings that are passed as a parameter, namely `OperationRetryTimeout`. 
   
   ### To Reproduce
   Passing a ClientConfig to the function. 
   
   ### Expected behavior
   The function should extract information from ClientConfig and use them to create a `ZkConnectionManager`.
   
   ### Additional context
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] jiajunwang commented on issue #1682: SharedZkClientFactory.buildZkClient (for HelixClient) does not respect ClientConfig settings

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1682:
URL: https://github.com/apache/helix/issues/1682#issuecomment-807917598


   This is the design actually. The shared ZkClients are using the same connection and raw ZkClient underlying. So it is always using the default value. If we want to differentiate every different setup, then we probably should deprecate the shared ZkClient since there might be nothing to share (because each object has some slightly different setup).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org