[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

["TanYuxin-tyx (via GitHub)" <gi...@apache.org>]

TanYuxin-tyx commented on code in PR #22833:
URL: https://github.com/apache/flink/pull/22833#discussion_r1241083625


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferAccumulator.java:
##########
@@ -46,7 +46,10 @@ public interface BufferAccumulator extends AutoCloseable {
      * transformed into finished buffers.
      */
     void receive(
-            ByteBuffer record, TieredStorageSubpartitionId subpartitionId, Buffer.DataType dataType)
+            ByteBuffer record,
+            TieredStorageSubpartitionId subpartitionId,
+            Buffer.DataType dataType,
+            boolean isBroadcast)

Review Comment:
   For a broadcast-only partition, When isBroadcast is true, the subpartitionId is 0. 
   
   For a non-broadcast-only partition (for exampe, a all-to-all edge), this will be all the subpartitionId range from 0 to numSupartitions(This is from a for loop).
   



##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferAccumulator.java:
##########
@@ -46,7 +46,10 @@ public interface BufferAccumulator extends AutoCloseable {
      * transformed into finished buffers.
      */
     void receive(
-            ByteBuffer record, TieredStorageSubpartitionId subpartitionId, Buffer.DataType dataType)
+            ByteBuffer record,
+            TieredStorageSubpartitionId subpartitionId,
+            Buffer.DataType dataType,
+            boolean isBroadcast)

Review Comment:
   For a broadcast-only partition, When isBroadcast is true, the subpartitionId is 0. 
   
   For a non-broadcast-only partition (for example, a all-to-all edge), this will be all the subpartitionId range from 0 to numSupartitions(This is from a for loop).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org