You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/02 09:20:59 UTC

[jira] [Commented] (OOZIE-815) Remove select * from queries related to coord action

    [ https://issues.apache.org/jira/browse/OOZIE-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266401#comment-13266401 ] 

jiraposter@reviews.apache.org commented on OOZIE-815:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/#review7461
-----------------------------------------------------------

Ship it!


+1

- Mohammad


On 2012-04-27 23:22:30, Virag Kothari wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4794/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-27 23:22:30)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/OOZIE-815
bq.  
bq.  Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.
bq.  
bq.  
bq.  This addresses bug oozie-815.
bq.      https://issues.apache.org/jira/browse/oozie-815
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1331614 
bq.    trunk/core/src/main/resources/oozie-default.xml 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1331614 
bq.    trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1331614 
bq.    trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1331614 
bq.  
bq.  Diff: https://reviews.apache.org/r/4794/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran the test suite and also the cron, mapreduce example
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Virag
bq.  
bq.


                
> Remove select * from queries related to coord action
> ----------------------------------------------------
>
>                 Key: OOZIE-815
>                 URL: https://issues.apache.org/jira/browse/OOZIE-815
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>            Assignee: Virag Kothari
>
> Currently oozie brings all actions into memory when certain cmds are run. If a coordjob has thousands of actions, clicking the job multiple times on webconsole will bring huge number of actions in memory causing OOM.
> Oozie-587 removes select * queries used in statustransitservice and suspend, resume, kill cmds. This jira proposes to remove select * from other queries like jobinfo and other cmds. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira