You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/25 07:30:57 UTC
[GitHub] [ignite] J-Bakuli opened a new pull request, #10215: IGNITE-17537 Append units for duration -sec and timeout -ms
J-Bakuli opened a new pull request, #10215:
URL: https://github.com/apache/ignite/pull/10215
Appended units to duration - sec and timeout - ms. The change is required as the execution of control.sh --tx command produces output of matching transactions (below) from which it is unclear that duration is provided in seconds while timeout is in milliseconds.
The result of executing control.sh --tx command is below. The **in bold** change is added in this PR:
Tx: [xid=fdc4d720281-00000000-0fd8-0177-0000-000000000012, label=null, state=ACTIVE, startTime=2022-07-06 05:05:07.432, duration=778 **sec**, isolation=REPEATABLE_READ, concurrency=PESSIMISTIC, topVer=AffinityTopologyVersion [topVer=199, minorTopVer=0], timeout=40000 **ms**, ...].
1) VisorTxInfo class:
https://github.com/apache/ignite/blob/bf9a460eccd07701cacac2a414c65707243350f1/modules/core/src/main/java/org/apache/ignite/internal/visor/tx/VisorTxInfo.java#L286
https://github.com/apache/ignite/blob/bf9a460eccd07701cacac2a414c65707243350f1/modules/core/src/main/java/org/apache/ignite/internal/visor/tx/VisorTxInfo.java#L290
2) long duration from getDuration() is in milliseconds as per VisorTxTask class: https://github.com/apache/ignite/blob/f6e2ebe8e62b3e442bda2a70f19544261b3c0cfa/modules/core/src/main/java/org/apache/ignite/internal/visor/tx/VisorTxTask.java#L243
3) long timeout is in milliseconds as per IgniteInternalTx interface: https://github.com/apache/ignite/blob/e2008f4652544e51c75a8586ef8aee82fb2923b9/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteInternalTx.java#L148
From the above 1) -3) after dividing into 1000 the duration is in seconds while timeout is still in milliseconds which should be explicitly highlighted.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on pull request #10215: IGNITE-17537 Append units for duration -sec and timeout -ms
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on PR #10215:
URL: https://github.com/apache/ignite/pull/10215#issuecomment-1227343465
@J-Bakuli could we also use `sec` or `ms` for both values to make output more friendly?
Seconds looks like a better choice for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #10215: IGNITE-17537 Append units for duration -sec and timeout -sec
Posted by GitBox <gi...@apache.org>.
anton-vinogradov merged PR #10215:
URL: https://github.com/apache/ignite/pull/10215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on pull request #10215: IGNITE-17537 Append units for duration -sec and timeout -ms
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on PR #10215:
URL: https://github.com/apache/ignite/pull/10215#issuecomment-1227122180
@anton-vinogradov, please review my changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on pull request #10215: IGNITE-17537 Append units for duration -sec and timeout -sec
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on PR #10215:
URL: https://github.com/apache/ignite/pull/10215#issuecomment-1228179678
LGTM, started the recheck https://tcbot2.sbt-ignite-dev.ru/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/10215/head&action=Latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org