You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/22 03:44:21 UTC

[GitHub] [apisix] HelloBug0 opened a new pull request #2813: docs: modify a typo

HelloBug0 opened a new pull request #2813:
URL: https://github.com/apache/apisix/pull/2813


   ### What this PR does / why we need it:
   Find a typo, so I modify it.
   
   ### Pre-submission checklist:
   
   * [X] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [X] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming merged pull request #2813: docs: modify a typo

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2813:
URL: https://github.com/apache/apisix/pull/2813


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2813: docs: modify a typo

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2813:
URL: https://github.com/apache/apisix/pull/2813#issuecomment-731698238


   where is the typo？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2813: docs: modify a typo

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2813:
URL: https://github.com/apache/apisix/pull/2813#discussion_r528286172



##########
File path: doc/zh-cn/how-to-build.md
##########
@@ -106,7 +106,7 @@ Makefile rules:
 ## 4. 运行测试案例
 
 1. 先安装 perl 的包管理器 cpanminus
-2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
+2. 然后通过 cpanm 来安装 test-nginx：`sudo cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`

Review comment:
       It would be better if you also fix the one in the English version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org