You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/10 11:50:34 UTC
[GitHub] [iceberg] pvary opened a new pull request #1902: Hive: Enhance iceberg.hive.engine.enabled documentation
pvary opened a new pull request #1902:
URL: https://github.com/apache/iceberg/pull/1902
Based on #1850 we need to enhance the documentation to mention that everyone modifying the table should use the `iceberg.engine.hive.enabled` config so the Hive parameters are not removed from the table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] massdosage commented on a change in pull request #1902: Hive: Enhance iceberg.hive.engine.enabled documentation
Posted by GitBox <gi...@apache.org>.
massdosage commented on a change in pull request #1902:
URL: https://github.com/apache/iceberg/pull/1902#discussion_r540128243
##########
File path: site/docs/hive.md
##########
@@ -57,7 +57,7 @@ Iceberg tables created using `HiveCatalog` are automatically registered with Hiv
The first step is to create an Iceberg table using the Spark/Java/Python API and `HiveCatalog`. For the purposes of this documentation we will assume that the table is called `table_b` and that the table location is `s3://some_path/table_b`. In order for Iceberg to correctly set up the Hive table for querying some configuration values need to be set, the two options for this are described below - you can use either or the other depending on your use case.
##### Hive Configuration
-The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so:
+The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating or modifying (alter/insert etc) the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so:
Review comment:
```suggestion
The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating or modifying (altering, inserting etc.) the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1902: Hive: Enhance iceberg.hive.engine.enabled documentation
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1902:
URL: https://github.com/apache/iceberg/pull/1902#issuecomment-742811103
Looks good to me. The question I asked in a comment is not related to the PR, so I merged it. Thanks @pvary and @massdosage!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1902: Hive: Enhance iceberg.hive.engine.enabled documentation
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1902:
URL: https://github.com/apache/iceberg/pull/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1902: Hive: Enhance iceberg.hive.engine.enabled documentation
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1902:
URL: https://github.com/apache/iceberg/pull/1902#discussion_r540509028
##########
File path: site/docs/hive.md
##########
@@ -57,7 +57,7 @@ Iceberg tables created using `HiveCatalog` are automatically registered with Hiv
The first step is to create an Iceberg table using the Spark/Java/Python API and `HiveCatalog`. For the purposes of this documentation we will assume that the table is called `table_b` and that the table location is `s3://some_path/table_b`. In order for Iceberg to correctly set up the Hive table for querying some configuration values need to be set, the two options for this are described below - you can use either or the other depending on your use case.
##### Hive Configuration
-The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so:
+The value `iceberg.engine.hive.enabled` needs to be set to `true` and added to the Hive configuration file on the classpath of the application creating or modifying (altering, inserting etc.) the table. This can be done by modifying the relevant `hive-site.xml`. Alternatively this can be done programmatically like so:
Review comment:
Should we set the table property when a table is created from Hive with this enabled? That way it would take effect for all engines by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org