You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2012/09/21 00:49:08 UTC
[jira] [Created] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Keith Wall created QPID-4338:
--------------------------------
Summary: Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
Key: QPID-4338
URL: https://issues.apache.org/jira/browse/QPID-4338
Project: Qpid
Issue Type: Improvement
Reporter: Keith Wall
Assignee: Keith Wall
Fix For: 0.19
Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473208#comment-13473208 ]
Philip Harvey commented on QPID-4338:
-------------------------------------
Mostly looks good, although I have only eyeballed the new charts so far (not the svn diff).
The baseline bar on the latency charts is now very nearly the same colour as the main bar. Is it possible to make it a more different colour?
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4338:
-----------------------------
Status: Ready To Review (was: In Progress)
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4338:
-----------------------------------
Assignee: Keith Wall (was: Philip Harvey)
back to you
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4338-Java-Performance-Charts-Renamed-SeriesStok.patch
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4338) Performance tests charting:
Support long chart descriptions and allow colour/stroke to be controlled
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473208#comment-13473208 ]
Philip Harvey edited comment on QPID-4338 at 10/10/12 2:46 PM:
---------------------------------------------------------------
Mostly looks good, although I have only eyeballed the new charts so far (not the svn diff).
The baseline bar on the latency charts is now very nearly the same colour as the main bar. Is it possible to make it a more different colour?
Also, I think the "Impact of Message Size" graphs that use bytes/s should say so in their title to make it more obvious how they differ from the messages/s graphs with the same title.
was (Author: philharveyonline):
Mostly looks good, although I have only eyeballed the new charts so far (not the svn diff).
The baseline bar on the latency charts is now very nearly the same colour as the main bar. Is it possible to make it a more different colour?
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4338:
-----------------------------
Component/s: Java Tests
Priority: Minor (was: Major)
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4338) Performance tests charting:
Support long chart descriptions and allow colour/stroke to be controlled
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503569#comment-13503569 ]
Keith Wall edited comment on QPID-4338 at 11/25/12 10:54 PM:
-------------------------------------------------------------
Phil's refactoring committed. I've addressed his comments re the impact of message size chart titles (now clarified as suggested). Phil and I discussed the colour comment and agreed no further action required.
was (Author: k-wall):
Phil' refactoring committed. I've addressed his comments re the impact of message size chart titles (now clarified as suggested). Phil and I discussed the colour comment and agreed no further action required.
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4338-Java-Performance-Charts-Renamed-SeriesStok.patch
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4338:
--------------------------------
Attachment: 0001-QPID-4338-Java-Performance-Charts-Renamed-SeriesStok.patch
I reviewed the code and have attached a patch containing some suggested improvements.
My previous comments regarding the colours and graph titles still stand - let's discuss how to address these.
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4338-Java-Performance-Charts-Renamed-SeriesStok.patch
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4338:
--------------------------------
Assignee: Philip Harvey (was: Keith Wall)
Patch applied
Hi Phil,
Could you review this commit please? Rev to be reviewed is 1388256. Thanks.
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4338) Performance tests charting: Support
long chart descriptions and allow colour/stroke to be controlled
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-4338.
------------------------------
Resolution: Fixed
Phil' refactoring committed. I've addressed his comments re the impact of message size chart titles (now clarified as suggested). Phil and I discussed the colour comment and agreed no further action required.
> Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled
> ----------------------------------------------------------------------------------------------------
>
> Key: QPID-4338
> URL: https://issues.apache.org/jira/browse/QPID-4338
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4338-Java-Performance-Charts-Renamed-SeriesStok.patch
>
>
> Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).
> Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org