You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Вадим Опольский <va...@gmail.com> on 2017/03/24 12:48:25 UTC
ready for review IGNITE-933
Hello everyone!
Denis, Valentin, what should I do to close issue
https://issues.apache.org/jira/browse/IGNITE-1794 ?
The tests in Team City executed successfully.
Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite.
Can you create TeamCity Configuration ?
Vadim Opolski
2017-03-21 11:30 GMT+03:00 Вадим Опольский <va...@gmail.com>:
> Hello everybody.
>
> The issue https://issues.apache.org/jira/browse/IGNITE-1794 fixed
> originally by Mykola Pereyma.
> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 on
> myself, because we haven’t got a note from him for a while.
>
> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 with
> my fork.
> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java
> as per CI comments.
> The tests from list below executed succesfully.
>
> Prepared new pull request - https://github.com/apache/ignite/pull/1643
>
> What's the next step ?
>
> Tests:
> HibernateL2CacheConfigurationSelfTest.java
> HibernateL2CacheSelfTest.java
> HibernateL2CacheTransactionalSelfTest.java
> HibernateL2CacheTransactionalUseSyncSelfTest.java
> CacheHibernateBlobStoreNodeRestartTest.java
> CacheHibernateBlobStoreSelfTest.java
> CacheHibernateStoreFactorySelfTest.java
> CacheHibernateStoreSessionListenerSelfTest.java
>
>
> Vadim Opolski
>
>
> 2017-02-25 2:38 GMT+03:00 Denis Magda <dm...@apache.org>:
>
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>
>> Just re-assign it on yourself ;) Hope that Mykola is fine with this
>> because we haven’t got a note from him for a while.
>>
>> —
>> Denis
>>
>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <va...@gmail.com>
>> wrote:
>> >
>> > Hi Denis,
>> >
>> > OK, I spotted the problem in the code and I will be try to resolve it.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> >
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>> >
>> > Vadim Opolski
>> >
>> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:
>> dmagda@apache.org>>:
>> > Hi Vadim,
>> >
>> > Yes, this issue might be still relevant. I can’t guide you through but,
>> basically, you need to reproduce the issue, spot it in the code and propose
>> a fix.
>> >
>> > BTW, do you have any experience with Hibernate? If so, I would be
>> amazing if you pick up this ticket reassigning on yourself:
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794> <
>> https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>>
>> >
>> > —
>> > Denis
>> >
>> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopolskij@gmail.com
>> <ma...@gmail.com>> wrote:
>> > >
>> > > Dear sirs !
>> > >
>> > > I want to resolve issue IGNITE-933
>> > >
>> > > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> > >
>> > > Is it actual ?
>> > >
>> > > In which class and method you want me to make changes ?
>> > >
>> > > Vadim Opolski
>> >
>> >
>>
>>
>
Re: ready for review IGNITE-933
Posted by Denis Magda <dm...@apache.org>.
Hi Vadim,
Great, thanks for catching up this ticket! I’ve created a TeamCity configuration for Hibernate 5:
http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_IgniteHibernate5&branch_IgniteTests=%3Cdefault%3E&tab=buildTypeStatusDiv <http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_IgniteHibernate5&branch_IgniteTests=%3Cdefault%3E&tab=buildTypeStatusDiv>
Please make sure the tests are agree on Team City and let Sam Boykov and the rest of the dev list know when the ticket is ready for the next review round.
—
Denis
> On Mar 24, 2017, at 5:48 AM, Вадим Опольский <va...@gmail.com> wrote:
>
> Hello everyone!
>
> Denis, Valentin, what should I do to close issue https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> ?
>
> The tests in Team City executed successfully.
>
> Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite. Can you create TeamCity Configuration ?
>
> Vadim Opolski
>
> 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopolskij@gmail.com <ma...@gmail.com>>:
> Hello everybody.
>
> The issue https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> fixed originally by Mykola Pereyma.
> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> on myself, because we haven’t got a note from him for a while.
>
> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 <https://github.com/apache/ignite/pull/1146> with my fork.
> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java as per CI comments.
> The tests from list below executed succesfully.
>
> Prepared new pull request - https://github.com/apache/ignite/pull/1643 <https://github.com/apache/ignite/pull/1643>
>
> What's the next step ?
>
> Tests:
> HibernateL2CacheConfigurationSelfTest.java
> HibernateL2CacheSelfTest.java
> HibernateL2CacheTransactionalSelfTest.java
> HibernateL2CacheTransactionalUseSyncSelfTest.java
> CacheHibernateBlobStoreNodeRestartTest.java
> CacheHibernateBlobStoreSelfTest.java
> CacheHibernateStoreFactorySelfTest.java
> CacheHibernateStoreSessionListenerSelfTest.java
>
>
> Vadim Opolski
>
>
> 2017-02-25 2:38 GMT+03:00 Denis Magda <dmagda@apache.org <ma...@apache.org>>:
> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is interesting for me. How I can assignee it to me? It is assigning with Mykola Pereyma now.
> >
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> <https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>
>
> Just re-assign it on yourself ;) Hope that Mykola is fine with this because we haven’t got a note from him for a while.
>
> —
> Denis
>
> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopolskij@gmail.com <ma...@gmail.com>> wrote:
> >
> > Hi Denis,
> >
> > OK, I spotted the problem in the code and I will be try to resolve it.
> >
> > https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933> <https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>>
> >
> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is interesting for me. How I can assignee it to me? It is assigning with Mykola Pereyma now.
> >
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> <https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>
> >
> > Vadim Opolski
> >
> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dmagda@apache.org <ma...@apache.org> <mailto:dmagda@apache.org <ma...@apache.org>>>:
> > Hi Vadim,
> >
> > Yes, this issue might be still relevant. I can’t guide you through but, basically, you need to reproduce the issue, spot it in the code and propose a fix.
> >
> > BTW, do you have any experience with Hibernate? If so, I would be amazing if you pick up this ticket reassigning on yourself:
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> <https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>> <https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794> <https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>>
> >
> > —
> > Denis
> >
> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopolskij@gmail.com <ma...@gmail.com> <mailto:vaopolskij@gmail.com <ma...@gmail.com>>> wrote:
> > >
> > > Dear sirs !
> > >
> > > I want to resolve issue IGNITE-933
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933> <https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>>
> > >
> > > Is it actual ?
> > >
> > > In which class and method you want me to make changes ?
> > >
> > > Vadim Opolski
> >
> >
>
>
>