You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/09 18:23:53 UTC
[GitHub] [beam] npetunin-clgx opened a new pull request #14980: [BEAM-12468] added bigquery specific project id property
npetunin-clgx opened a new pull request #14980:
URL: https://github.com/apache/beam/pull/14980
Add an optional property for BigQuery to set an alternative project ID (other than main project ID in GcpOptions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #14980:
URL: https://github.com/apache/beam/pull/14980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14980:
URL: https://github.com/apache/beam/pull/14980#issuecomment-870093978
thanks a lot for adding the tests! and an annotation for them too. It's great.
The RAT test failure is because the new annotation file needs the Apache License header at the top of it (you can copy from any other file).
To fix spotless checks you can run `./gradlew :sdks:java:io:google-cloud-platform:spotlessApply`, and to run tests locally you can use `./gradlew :sdks:java:io:google-cloud-platform:check` to make sure they pass if you want to check locally.
Once the tests are passing, I'll merge the change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14980:
URL: https://github.com/apache/beam/pull/14980#issuecomment-870093978
thanks a lot for adding the tests! and an annotation for them too. It's great.
The RAT test failure is because the new annotation file needs the Apache License header at the top of it (you can copy from any other file).
To fix spotless checks you can run `./gradlew :sdks:java:io:google-cloud-platform:spotlessApply`, and to run tests locally you can use `./gradlew :sdks:java:io:google-cloud-platform:check` to make sure they pass if you want to check locally.
Once the tests are passing, I'll merge the change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14980:
URL: https://github.com/apache/beam/pull/14980#issuecomment-863583325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14980:
URL: https://github.com/apache/beam/pull/14980#issuecomment-861854805
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14980: [BEAM-12468] added bigquery specific project id property
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14980:
URL: https://github.com/apache/beam/pull/14980#issuecomment-858033952
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org