[GitHub] [incubator-doris] vagetablechicken commented on issue #2235: Support setting properties for storage_root_path

[GitBox <gi...@apache.org>]

vagetablechicken commented on issue #2235: Support setting properties for storage_root_path
URL: https://github.com/apache/incubator-doris/pull/2235#issuecomment-555438703
 
 
   property medium has a higher priority, so I decide to set storage_medium in c'tor of DataDir, change 
   '_init_extension_and_capacity()' to '_init_capacity()'. 
   https://github.com/apache/incubator-doris/blob/14769b0beb7671626da011611d2c73ffe841b831/be/src/olap/data_dir.h#L132
   
   But in meta_tool, 
   https://github.com/apache/incubator-doris/blob/14769b0beb7671626da011611d2c73ffe841b831/be/src/tools/meta_tool.cpp#L143
   var 'data_dir' will not be set the _storage_medium, cause I remove the _init_extension part.
   
   I don't want to redefine TStorageMedium enum, e.g. {UNSET, HDD,SSD}.
   How about 
   ```
       DataDir(const std::string& path,
               int64_t capacity_bytes = -1,
               std::string medium_property = "",
               TabletManager* tablet_manager = nullptr,
               TxnManager* txn_manager = nullptr);
   ```
   Thus, 
   1. medium_property != "", set _storage_medium
   1. medium_property == "", use extension

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org