[jira] [Work logged] (HIVE-26952) set the value of metastore.storage.schema.reader.impl
 to org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26952?focusedWorklogId=839535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839535 ]

ASF GitHub Bot logged work on HIVE-26952:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/23 08:44
            Start Date: 17/Jan/23 08:44
    Worklog Time Spent: 10m 
      Work Description: tarak271 opened a new pull request, #3959:
URL: https://github.com/apache/hive/pull/3959

   …o org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   set the value of the config metastore.storage.schema.reader.impl
 to org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default. 
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Previously it was set to DefaultStorageSchemaReader with default message as "Storage schema reading not supported". SerDeStorageSchemaReader was introduced with implementation that can help read schema from storage. So proposing to make it as default value to avoid setting this config by users in future releases
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   There is no functionality change introduced, so existing test cases should not be failing with these config value changes




Issue Time Tracking
-------------------

            Worklog Id:     (was: 839535)
    Remaining Estimate: 0h
            Time Spent: 10m

> set the value of metastore.storage.schema.reader.impl
 to org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-26952
>                 URL: https://issues.apache.org/jira/browse/HIVE-26952
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>            Reporter: Taraka Rama Rao Lethavadla
>            Assignee: Taraka Rama Rao Lethavadla
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> With the default value of
>  
> {code:java}
> DefaultStorageSchemaReader.class.getName(){code}
>  
> in the Metastore Config, *metastore.storage.schema.reader.impl*
> below exception is thrown when trying to read Avro schema
> {noformat}
> Caused by: org.apache.hive.service.cli.HiveSQLException: MetaException (message:java.lang.UnsupportedOperationException: Storage schema reading not supported)
>     at org.apache.hive.service.cli.operation.GetColumnsOperation.runInternal(GetColumnsOperation.java:213)
>     at org.apache.hive.service.cli.operation.Operation.run(Operation.java:247)
>     at org.apache.hive.service.cli.session.HiveSessionImpl.getColumns(HiveSessionImpl.java:729)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at org.apache.hive.service.cli.session.HiveSessionProxy.invoke(HiveSessionProxy.java:78)
>     at org.apache.hive.service.cli.session.HiveSessionProxy.access-zsh(HiveSessionProxy.java:36)
>     at org.apache.hive.service.cli.session.HiveSessionProxy.run(HiveSessionProxy.java:63)
>     at java.security.AccessController.doPrivileged(Native Method)
>     at javax.security.auth.Subject.doAs(Subject.java:422)
>     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>     at org.apache.hive.service.cli.session.HiveSessionProxy.invoke(HiveSessionProxy.java:59)
>     at com.sun.proxy..getColumns(Unknown Source)
>     at org.apache.hive.service.cli.CLIService.getColumns(CLIService.java:390){noformat}
> setting the above config with *org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader* resolves issue
> Proposing to make this value as default in code base, so that in upcoming versions we don't have to set this value manually



--
This message was sent by Atlassian Jira
(v8.20.10#820010)