You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/18 11:36:41 UTC
[GitHub] [spark] yzjg opened a new pull request #31582: window function comment error
yzjg opened a new pull request #31582:
URL: https://github.com/apache/spark/pull/31582
functions.scala window function comment error:
as the comment is,the schema is timestamp:TimestampType, when apply the window function using time column that isn't exist,this can easy lead to misunderstand
can contributor help me to merge the pull request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781756802
Merged to master, branch-3.1, branch-3.0 and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781293942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781756283
@yzjg, I updated the PR description for you this time but let's make sure we keep the PR description template next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781459906
**[Test build #135233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135233/testReport)** for PR 31582 at commit [`3a4702d`](https://github.com/apache/spark/commit/3a4702d9cd967c3c99325339e72c8b992f68789a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781442388
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781606225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135233/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781506098
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39813/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31582:
URL: https://github.com/apache/spark/pull/31582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yzjg commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
yzjg commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781294509
> @yzjg do you mind keeping the GitHub PR template: https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE?
Ok,thank you HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781289644
@yzjg do you mind keeping the GitHub PR template: https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781459906
**[Test build #135233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135233/testReport)** for PR 31582 at commit [`3a4702d`](https://github.com/apache/spark/commit/3a4702d9cd967c3c99325339e72c8b992f68789a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781605245
**[Test build #135233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135233/testReport)** for PR 31582 at commit [`3a4702d`](https://github.com/apache/spark/commit/3a4702d9cd967c3c99325339e72c8b992f68789a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781530444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39813/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781485424
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39813/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781606225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135233/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31582: [MINOR][SQL][DOCS] Fix the comments in the example at window function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31582:
URL: https://github.com/apache/spark/pull/31582#issuecomment-781293942
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org