[GitHub] [kafka] clolov commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse

["clolov (via GitHub)" <gi...@apache.org>]

clolov commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1568117181

   > I have a few comments/questions:
   > 
   >     1. I am not really comfortable with merging this without the server side implementation. @clolov Is there a strong reason to not do them together?
   > 
   >     2. I agree with @Hangleton that it may be better to start with adding the TopicId only. This is complicated enough on its own. We can the other fields afterwards.
   > 
   >     3. I agree with @jolshan that we should set `"latestVersionUnstable": true` while in development.
   
   I will accommodate 2 and 3 in subsequent commits. There was no reason for 1 other than splitting the pull request into nicer to review chunks. I am happy with trying to put Request/Respone changes + server side changes + tests in the same pull request similar to https://github.com/apache/kafka/pull/13240.
   
   Thank you all for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org