[jira] Commented: (WICKET-670) Bring back the inspector!

["Eelco Hillenius (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506004 ] 

Eelco Hillenius commented on WICKET-670:
----------------------------------------

> It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.

I'm still not completely sure how acurate the picture is we are displaying there. When I did testing I found there was a big difference between how many users I could support with a certain ammount of MBs based on what the inspector says and how much memory I actually consumed when I tested with that number of sessions. Gladly, always in favor of the real situation. This is even true when you include the wicket-objectsizeof-agent project for your measurings, which should give a much better estimate anyway.

Anyway... I agree it is a nice toy and it would be nice to have this available for people as long as they understand that it's best estimates rather than a hard numbers they are seeing.

> 1. fix the inspector
>
> - it needs to factor out the stack trace metadata so sizes of things are more accurate 

Stack trace meta data is removed at the end of requests, so the only polluted number you are seeing might be of the inspector page itself.

> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() ...

I think it is a better idea to ship just the inspector panel, not the page. That way people can decide for themselves how to include and protect it, and we don't have to litter our settings any more :).

> Bring back the inspector!
> -------------------------
>
>                 Key: WICKET-670
>                 URL: https://issues.apache.org/jira/browse/WICKET-670
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 1.4.0-alpha
>            Reporter: Jonathan Locke
>            Priority: Minor
>             Fix For: 1.4.0-alpha
>
>
> My copy of the inspector is completely broken.  It's a shame that this useful tool is not really supported anymore.  It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.  
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
>  - it needs to factor out the stack trace metadata so sizes of things are more accurate
>  - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.