You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Noah Levitt (JIRA)" <ji...@apache.org> on 2011/04/04 22:07:05 UTC

[jira] [Created] (NET-399) ftp data connection does not use connectTimeout

ftp data connection does not use connectTimeout
-----------------------------------------------

                 Key: NET-399
                 URL: https://issues.apache.org/jira/browse/NET-399
             Project: Commons Net
          Issue Type: Bug
          Components: FTP
    Affects Versions: 2.2, 2.0
            Reporter: Noah Levitt


Deep inside the lengthy method org.apache.commons.net.ftp.FTPClient._openDataConnection_(int, String) we find this line

            socket = _socketFactory_.createSocket(__passiveHost, __passivePort);

Which I believe does not set the connect timeout when opening the connection. If the line were changed to the following, it would use the connectTimeout property. 

            socket = connect(__passiveHost, __passivePort)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (NET-399) ftp data connection does not use connectTimeout

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-399.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.0

> ftp data connection does not use connectTimeout
> -----------------------------------------------
>
>                 Key: NET-399
>                 URL: https://issues.apache.org/jira/browse/NET-399
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 2.0, 2.2
>            Reporter: Noah Levitt
>             Fix For: 3.0
>
>
> Deep inside the lengthy method org.apache.commons.net.ftp.FTPClient._openDataConnection_(int, String) we find this line
>             socket = _socketFactory_.createSocket(__passiveHost, __passivePort);
> Which I believe does not set the connect timeout when opening the connection. If the line were changed to the following, it would use the connectTimeout property. 
>             socket = connect(__passiveHost, __passivePort)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (NET-399) ftp data connection does not use connectTimeout

Posted by "Sebb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015690#comment-13015690 ] 

Sebb commented on NET-399:
--------------------------

It's true that the connect timeout is not set currently.

However the connect() methods in SocketClient are specific to the control connection so cannot be used here.

> ftp data connection does not use connectTimeout
> -----------------------------------------------
>
>                 Key: NET-399
>                 URL: https://issues.apache.org/jira/browse/NET-399
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 2.0, 2.2
>            Reporter: Noah Levitt
>
> Deep inside the lengthy method org.apache.commons.net.ftp.FTPClient._openDataConnection_(int, String) we find this line
>             socket = _socketFactory_.createSocket(__passiveHost, __passivePort);
> Which I believe does not set the connect timeout when opening the connection. If the line were changed to the following, it would use the connectTimeout property. 
>             socket = connect(__passiveHost, __passivePort)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira