You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "turcsanyip (via GitHub)" <gi...@apache.org> on 2025/11/21 08:42:26 UTC
[PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
turcsanyip opened a new pull request, #10553:
URL: https://github.com/apache/nifi/pull/10553
# Summary
[NIFI-15241](https://issues.apache.org/jira/browse/NIFI-15241)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10553:
URL: https://github.com/apache/nifi/pull/10553#issuecomment-3568789092
Ah yeah sorry I was reacting to the idea of bringing encrypted provenance back instead of what this PR actually does/is.
To the spirit of this PR itself it looks like what it aims to do is expand from package private to protected for many methods/fields of a couple provenance related classes. This would presumably allow someone else to write a provenance implementation in another package. For instance someone could write their own extension of this provenance extension in their own package which does say encrypted repos. Others being able to build their own thing is good!
However, if my understanding is correct what I don't think is good about this is we create an API contractual obligation we're not seeking. We don't want to be restricted in changing how our provenance stuff works. It isn't meant for someone else to extend and modify.
Why can't one simply copy our code and build their own solution? That creates no additional burden/obligation for us to maintain nor restricts our ability to change anything but does let those who wish to create their own provenance impl to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10553:
URL: https://github.com/apache/nifi/pull/10553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10553:
URL: https://github.com/apache/nifi/pull/10553#issuecomment-3572319648
Thanks @turcsanyip Yeah given we're all agreeing this is not going to expand our API obligations then I think this change is fine and happy that others could then build their own implementations as they wish (knowing they'd be subject to some change perhaps).
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on PR #10553:
URL: https://github.com/apache/nifi/pull/10553#issuecomment-3571056556
@joewitt Yes, this is not about bringing the encrypted provenance back here but allowing the extension mechanism in the form as it existed before but outside the upstream code. The code is not part of the NiFi API (`nifi-api` or `nifi-framework-api`) but it is in an extension bundle. So there is no API contractual obligation on the upstream side as we discussed above with @exceptionfactory. The risk of future changes lies on the vendor side.
For these reasons (that is, no new code/logic, no compatibility requirements), I still believe it could be added upstream without future commitment and risk from the upstream side.
Thanks for considering it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on PR #10553:
URL: https://github.com/apache/nifi/pull/10553#issuecomment-3567018772
@exceptionfactory Thanks for your feedback.
These methods were originally added for extension, which is why I believe we could still provide this option. The affected classes are not part of the framework API but reside in a framework extension module, where maintaining backward compatibility is not a strict requirement for the upstream side to fulfill. External dependents can use this code without an expectation of future compatibility, and if incompatible changes happen over time, they will need to adapt accordingly (potentially even by copying the source, if necessary). In other words, the risk lies on the dependent side.
Having said that, would it be possible to incorporate this PR into the upstream codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15241 Improved extensibility of Provenance Repository [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10553:
URL: https://github.com/apache/nifi/pull/10553#issuecomment-3567029519
The user base for this capability is very small. The developer base to maintain it within the community is very small. The risk of doing this wrong is very high. With that said I am not supportive of us adding this complexity back into the NiFi 2.x family until there is a very strong proposal for how and who would maintain this capability and its security implications.
Given the extension mechanism exists let a vendor do this and maintain it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org