You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Umesh Padashetty <us...@gmail.com> on 2019/03/18 13:18:55 UTC
Review Request 70229: Incorrect link of Advanced Search in Search Page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70229/
-----------------------------------------------------------
Review request for atlas and Nixon Rodrigues.
Bugs: https://issues.apache.org/jira/browse/ATLAS-3079
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3079
Repository: atlas
Description
-------
On the Atlas homepage, on click of next to Advanced toggle button, lists out a window. On click of "More sample queries and use-cases", it is taking the user to http://atlas.apache.org/Search.html which is throwing 404 error. This is because the page has moved to http://atlas.apache.org/Search-Advanced.html.
Diffs
-----
dashboardv2/public/js/templates/search/AdvancedSearchInfo_tmpl.html cce3096ac
Diff: https://reviews.apache.org/r/70229/diff/1/
Testing
-------
Verified that the new link is taking the user correctly to http://atlas.apache.org/Search-Advanced.html
Thanks,
Umesh Padashetty
Re: Review Request 70229: Broken Advanced Search and Git links
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70229/#review213819
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On March 19, 2019, 1:17 p.m., Umesh Padashetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70229/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 1:17 p.m.)
>
>
> Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
>
>
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3079
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3079
>
>
> Repository: atlas
>
>
> Description
> -------
>
> On the Atlas homepage, on click of next to Advanced toggle button, lists out a window. On click of "More sample queries and use-cases", it is taking the user to http://atlas.apache.org/Search.html which is throwing 404 error. This is because the page has moved to http://atlas.apache.org/Search-Advanced.html.
>
> Also, update the links to https://gitbox.apache.org/repos/asf?p=atlas.git which were previously pointing to https://git-wip-us.apache.org/repos/asf?p=atlas.git
>
>
> Diffs
> -----
>
> dashboardv2/package.json 4d3d19fc0
> dashboardv2/public/js/templates/search/AdvancedSearchInfo_tmpl.html cce3096ac
> docs/pom.xml f5e544465
> docs/src/site/site.xml fdf9b4726
> pom.xml 533447845
>
>
> Diff: https://reviews.apache.org/r/70229/diff/2/
>
>
> Testing
> -------
>
> Verified that the new link is taking the user correctly to http://atlas.apache.org/Search-Advanced.html and https://gitbox.apache.org/repos/asf?p=atlas.git
>
>
> Thanks,
>
> Umesh Padashetty
>
>
Re: Review Request 70229: Broken Advanced Search and Git links
Posted by Umesh Padashetty <us...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70229/
-----------------------------------------------------------
(Updated March 19, 2019, 1:17 p.m.)
Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
Changes
-------
Updated Advanced Search and git broken links
Summary (updated)
-----------------
Broken Advanced Search and Git links
Bugs: https://issues.apache.org/jira/browse/ATLAS-3079
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3079
Repository: atlas
Description (updated)
-------
On the Atlas homepage, on click of next to Advanced toggle button, lists out a window. On click of "More sample queries and use-cases", it is taking the user to http://atlas.apache.org/Search.html which is throwing 404 error. This is because the page has moved to http://atlas.apache.org/Search-Advanced.html.
Also, update the links to https://gitbox.apache.org/repos/asf?p=atlas.git which were previously pointing to https://git-wip-us.apache.org/repos/asf?p=atlas.git
Diffs (updated)
-----
dashboardv2/package.json 4d3d19fc0
dashboardv2/public/js/templates/search/AdvancedSearchInfo_tmpl.html cce3096ac
docs/pom.xml f5e544465
docs/src/site/site.xml fdf9b4726
pom.xml 533447845
Diff: https://reviews.apache.org/r/70229/diff/2/
Changes: https://reviews.apache.org/r/70229/diff/1-2/
Testing (updated)
-------
Verified that the new link is taking the user correctly to http://atlas.apache.org/Search-Advanced.html and https://gitbox.apache.org/repos/asf?p=atlas.git
Thanks,
Umesh Padashetty
Re: Review Request 70229: Incorrect link of Advanced Search in Search
Page
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70229/#review213781
-----------------------------------------------------------
1. In the atlas home page - http://atlas.apache.org. The Menu link -> Apache Atlas -> Wiki link is also broken. Consider including the fix also part of this JIRA?
2. Also the git link in top menu points to outdated gihub link, can you update it to point to the new gitbox link of atlas
3. Update the developed access gitlink - http://atlas.apache.org/source-repository.html to the new gitbox link
- Sarath Subramanian
On March 18, 2019, 6:18 a.m., Umesh Padashetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70229/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 6:18 a.m.)
>
>
> Review request for atlas and Nixon Rodrigues.
>
>
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3079
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3079
>
>
> Repository: atlas
>
>
> Description
> -------
>
> On the Atlas homepage, on click of next to Advanced toggle button, lists out a window. On click of "More sample queries and use-cases", it is taking the user to http://atlas.apache.org/Search.html which is throwing 404 error. This is because the page has moved to http://atlas.apache.org/Search-Advanced.html.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/templates/search/AdvancedSearchInfo_tmpl.html cce3096ac
>
>
> Diff: https://reviews.apache.org/r/70229/diff/1/
>
>
> Testing
> -------
>
> Verified that the new link is taking the user correctly to http://atlas.apache.org/Search-Advanced.html
>
>
> Thanks,
>
> Umesh Padashetty
>
>