[GitHub] [hbase] apurtell edited a comment on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

[GitBox <gi...@apache.org>]

apurtell edited a comment on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#issuecomment-550580191
 
 
   > TestHBlock.testBlockHeapSize seems to be failing because the extra fields on the HFileContext are changing the estimate of the class heap size.
   
   > Are the HFileContexts actually being serialized into the HFile?
   
   No.
   
   > I don't see any place where the HFileContext is being serialized into the HFile, but if not then I'm confused why we're asserting on an exact heap footprint of a purely in-memory class,
   
   We track the overhead of keeping various structures around on heap (and related structures associated by field references to them). Update FIXED_OVERHEAD to account for two new array references and update heapSize() to include the current array lengths - i.e. fix the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services