[GitHub] [spark] clarkead commented on a change in pull request #27370: [SPARK-30654] Bootstrap4 WebUI upgrade

[GitBox <gi...@apache.org>]

clarkead commented on a change in pull request #27370: [SPARK-30654] Bootstrap4 WebUI upgrade
URL: https://github.com/apache/spark/pull/27370#discussion_r386619949
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
 ##########
 @@ -562,10 +562,10 @@ $(document).ready(function () {
 
                 $("#showAdditionalMetrics").append(
                     "<div><a id='additionalMetrics'>" +
-                    "<span class='expand-input-rate-arrow arrow-closed' id='arrowtoggle-optional-metrics'></span>" +
+                    "<span class='expand-input-rate-arrow arrow-closed' id='arrowtoggle-optional-metrics'></span> " +
                     "Show Additional Metrics" +
                     "</a></div>" +
-                    "<div class='container-fluid container-fluid-div' id='toggle-metrics' hidden>" +
+                    "<div class='container-fluid-div ml-4 d-none' id='toggle-metrics'>" +
 
 Review comment:
   The ml-4 is needed to add the left margin on the set of checkboxes so that it is indented similarly to the original / current formatting.  Without the ml-4 class the checkboxes are flush with the "Show Additional Metrics" arrow.
   
   With regards to d-none, jQuery 1.8 deprecated .toggle() and jQuery 1.9 removed it so I had to change the JS for the "Show Additional Metrics" expand/collapse functionality.  I decided to change it to the jQuery .toggleClass() method and use the Bootstrap provided d-none (display none) class to show and hide the div instead of creating a new custom class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org