You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/08/20 12:16:49 UTC
[GitHub] [bookkeeper] sijia-w opened a new pull request #2400: ISSUE #1979 Metrics link missing
sijia-w opened a new pull request #2400:
URL: https://github.com/apache/bookkeeper/pull/2400
Fixes #1979
The link for `Metrics` is broken. However, the `Metrics` file is empty. Therefore, I temporarily removed the link in all versions. The same problem happened to `configuration parameters`.
I closed pr #2386 as it brought changes from the master instead of a new branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijia-w commented on pull request #2400: ISSUE #1979 Metrics link missing
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #2400:
URL: https://github.com/apache/bookkeeper/pull/2400#issuecomment-677707657
@Jennifer88huang Thanks very much for your comments. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Jennifer88huang commented on a change in pull request #2400: ISSUE #1979 Metrics link missing
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #2400:
URL: https://github.com/apache/bookkeeper/pull/2400#discussion_r474016214
##########
File path: site/docs/4.10.0/admin/metrics.md
##########
@@ -22,7 +22,7 @@ Provider | Provider class name
## Enabling stats providers in bookies
-There are two stats-related [configuration parameters](../../reference/config#statistics) available for bookies:
+There are two stats-related [configuration parameters](../../reference/config/) available for bookies:
Review comment:
```suggestion
Two stats-related [configuration parameters](../../reference/config/) parameters are available for bookies:
```
##########
File path: site/docs/4.10.0/admin/metrics.md
##########
@@ -4,7 +4,7 @@ title: Metric collection
BookKeeper enables metrics collection through a variety of [stats providers](#stats-providers).
-> For a full listing of available metrics, see the [Metrics](../../reference/metrics) reference doc.
+> For a full listing of available metrics, see the Metrics reference doc.
Review comment:
Since the Metrics reference has no content at all, I suggest that we just remove this sentence.
##########
File path: site/docs/4.10.0/admin/metrics.md
##########
@@ -22,7 +22,7 @@ Provider | Provider class name
## Enabling stats providers in bookies
-There are two stats-related [configuration parameters](../../reference/config#statistics) available for bookies:
+There are two stats-related [configuration parameters](../../reference/config/) available for bookies:
Review comment:
Avoid using "there be" in technical writing.
See IBM style guides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2400: ISSUE #1979 Metrics link missing
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2400:
URL: https://github.com/apache/bookkeeper/pull/2400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org