You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/23 08:33:47 UTC
[GitHub] [dubbo-go] alchemy-lee opened a new pull request #1339: Use class name as the default reference name
alchemy-lee opened a new pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
This PR removes `RPCService` and uses the class name as the default reference name.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e441a84) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/92df41cfde9727756e9bc6e5b11e49fe0b649d24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92df41c) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e441a84 differs from pull request most recent head a2f1a2f. Consider uploading reports for the commit a2f1a2f to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
+ Coverage 56.17% 56.27% +0.09%
==========================================
Files 279 279
Lines 15355 15374 +19
==========================================
+ Hits 8626 8651 +25
+ Misses 5797 5795 -2
+ Partials 932 928 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `81.45% <100.00%> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <100.00%> (+1.20%)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `50.00% <100.00%> (+0.19%)` | :arrow_up: |
| [config/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2UuZ28=) | `82.35% <100.00%> (+2.35%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.76% <0.00%> (-3.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.02% <0.00%> (+2.19%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [92df41c...a2f1a2f](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c966ad) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.02%`.
> The diff coverage is `66.75%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
- Coverage 56.09% 56.07% -0.03%
==========================================
Files 273 279 +6
Lines 12779 15398 +2619
==========================================
+ Hits 7169 8634 +1465
- Misses 4705 5836 +1131
- Partials 905 928 +23
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| [filter/tps/strategy/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9zdHJhdGVneS9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86fe9e3...0c966ad](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#discussion_r675418196
##########
File path: config/service.go
##########
@@ -17,37 +17,43 @@
package config
+import (
+ "reflect"
+)
+
import (
"dubbo.apache.org/dubbo-go/v3/common"
)
var (
- conServices = map[string]common.RPCService{} // service name -> service
- proServices = map[string]common.RPCService{} // service name -> service
+ conServices = map[string]interface{}{} // service name -> service
+ proServices = map[string]interface{}{} // service name -> service
)
// SetConsumerService is called by init() of implement of RPCService
-func SetConsumerService(service common.RPCService) {
- conServices[service.Reference()] = service
+func SetConsumerService(service interface{}) {
+ ref := reflect.TypeOf(service).Elem().Name()
+ conServices[ref] = service
}
// SetProviderService is called by init() of implement of RPCService
-func SetProviderService(service common.RPCService) {
- proServices[service.Reference()] = service
+func SetProviderService(service interface{}) {
+ ref := reflect.TypeOf(service).Elem().Name()
Review comment:
这里有点小问题。
需要考虑是指针还是结构，还需要考虑包名的问题。如果用户在package pkg 下面定义了一个User结构，传入的是指针，这个ref将为“*pkg.User”，而用户希望用“User”作为key，这里可以做一下调整。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#discussion_r680614989
##########
File path: common/proxy/proxy.go
##########
@@ -110,7 +110,7 @@ func (p *Proxy) GetInvoker() protocol.Invoker {
}
// DefaultProxyImplementFunc the default function for proxy impl
-func DefaultProxyImplementFunc(p *Proxy, v common.RPCService) {
+func DefaultProxyImplementFunc(p *Proxy, v interface{}) {
Review comment:
这里保留 common.RPCService吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13d05d3) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.97%`.
> :exclamation: Current head 13d05d3 differs from pull request most recent head 99ec546. Consider uploading reports for the commit 99ec546 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
- Coverage 56.09% 56.09% -0.01%
==========================================
Files 273 278 +5
Lines 12779 15314 +2535
==========================================
+ Hits 7169 8590 +1421
- Misses 4705 5805 +1100
- Partials 905 919 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| [filter/tps/strategy/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9zdHJhdGVneS9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86fe9e3...99ec546](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] alchemy-lee commented on a change in pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
alchemy-lee commented on a change in pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#discussion_r680730033
##########
File path: common/proxy/proxy.go
##########
@@ -110,7 +110,7 @@ func (p *Proxy) GetInvoker() protocol.Invoker {
}
// DefaultProxyImplementFunc the default function for proxy impl
-func DefaultProxyImplementFunc(p *Proxy, v common.RPCService) {
+func DefaultProxyImplementFunc(p *Proxy, v interface{}) {
Review comment:
I have modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#discussion_r676457184
##########
File path: common/rpc_service.go
##########
@@ -42,6 +42,32 @@ type RPCService interface {
Reference() string
}
+// GetReference return the reference id of the service.
+// If the service implemented the RPCService interface,
+// it will call the Reference method; if not, it will
+// return the struct name as the reference id.
+func GetReference(service interface{}) string {
Review comment:
// GetReference returns the reference id of the service.
// If the service implemented the RPCService interface,
// it will call the Reference method. If not, it will
// return the struct name as the reference id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13d05d3) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.97%`.
> :exclamation: Current head 13d05d3 differs from pull request most recent head 0c966ad. Consider uploading reports for the commit 0c966ad to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
- Coverage 56.09% 56.09% -0.01%
==========================================
Files 273 278 +5
Lines 12779 15314 +2535
==========================================
+ Hits 7169 8590 +1421
- Misses 4705 5805 +1100
- Partials 905 919 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| [filter/tps/strategy/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9zdHJhdGVneS9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86fe9e3...0c966ad](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c966ad) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.02%`.
> The diff coverage is `66.75%`.
> :exclamation: Current head 0c966ad differs from pull request most recent head 3d85e2b. Consider uploading reports for the commit 3d85e2b to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
- Coverage 56.09% 56.07% -0.03%
==========================================
Files 273 279 +6
Lines 12779 15398 +2619
==========================================
+ Hits 7169 8634 +1465
- Misses 4705 5836 +1131
- Partials 905 928 +23
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| [filter/tps/strategy/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9zdHJhdGVneS9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86fe9e3...3d85e2b](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e441a84) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/92df41cfde9727756e9bc6e5b11e49fe0b649d24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92df41c) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
+ Coverage 56.17% 56.27% +0.09%
==========================================
Files 279 279
Lines 15355 15374 +19
==========================================
+ Hits 8626 8651 +25
+ Misses 5797 5795 -2
+ Partials 932 928 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `81.45% <100.00%> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <100.00%> (+1.20%)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `50.00% <100.00%> (+0.19%)` | :arrow_up: |
| [config/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2UuZ28=) | `82.35% <100.00%> (+2.35%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.76% <0.00%> (-3.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.02% <0.00%> (+2.19%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [92df41c...e441a84](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#issuecomment-886746070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1339](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2f1a2f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/92df41cfde9727756e9bc6e5b11e49fe0b649d24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92df41c) will **decrease** coverage by `1.20%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1339 +/- ##
==========================================
- Coverage 56.17% 54.97% -1.21%
==========================================
Files 279 272 -7
Lines 15355 14755 -600
==========================================
- Hits 8626 8111 -515
+ Misses 5797 5768 -29
+ Partials 932 876 -56
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <100.00%> (+1.20%)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `50.00% <100.00%> (+0.19%)` | :arrow_up: |
| [config/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2UuZ28=) | `82.35% <100.00%> (+2.35%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-43.23%)` | :arrow_down: |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.76% <0.00%> (-3.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | | |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | | |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | | |
| ... and [8 more](https://codecov.io/gh/apache/dubbo-go/pull/1339/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [92df41c...a2f1a2f](https://codecov.io/gh/apache/dubbo-go/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] alchemy-lee commented on a change in pull request #1339: Use class name as the default reference name
Posted by GitBox <gi...@apache.org>.
alchemy-lee commented on a change in pull request #1339:
URL: https://github.com/apache/dubbo-go/pull/1339#discussion_r676484893
##########
File path: common/rpc_service.go
##########
@@ -42,6 +42,32 @@ type RPCService interface {
Reference() string
}
+// GetReference return the reference id of the service.
+// If the service implemented the RPCService interface,
+// it will call the Reference method; if not, it will
+// return the struct name as the reference id.
+func GetReference(service interface{}) string {
Review comment:
I have modified it. 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org