You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2018/08/29 14:14:21 UTC
Review Request 68560: Updated the python2 'PyLinter' to only lint
python2 based code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Robin Gögge.
Bugs: MESOS-8770
https://issues.apache.org/jira/browse/MESOS-8770
Repository: mesos
Description
-------
Specifically, this includes no longer linting all code under the
`src/python` directory.
Diffs
-----
support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990
Diff: https://reviews.apache.org/r/68560/diff/1/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 68560: Updated the python2 'PyLinter' to only lint
python2 based code.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/#review208092
-----------------------------------------------------------
Ship it!
As we are migrating the Mesos python package to python 3.6 in a later commit, the last thing we want to lint when using Python 2 are the Python 2 suppport scripts. This patch is thus correct.
- Armand Grillet
On Aug. 29, 2018, 4:14 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68560/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 4:14 p.m.)
>
>
> Review request for mesos, Armand Grillet and Robin Gögge.
>
>
> Bugs: MESOS-8770
> https://issues.apache.org/jira/browse/MESOS-8770
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Specifically, this includes no longer linting all code under the
> `src/python` directory.
>
>
> Diffs
> -----
>
> support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990
>
>
> Diff: https://reviews.apache.org/r/68560/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 68560: Updated the python2 'PyLinter' to only lint
python2 based code.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/#review208097
-----------------------------------------------------------
PASS: Mesos patch 68560 was successfully built and tested.
Reviews applied: `['68560']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2260/mesos-review-68560
- Mesos Reviewbot Windows
On Aug. 29, 2018, 7:14 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68560/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 7:14 a.m.)
>
>
> Review request for mesos, Armand Grillet and Robin Gögge.
>
>
> Bugs: MESOS-8770
> https://issues.apache.org/jira/browse/MESOS-8770
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Specifically, this includes no longer linting all code under the
> `src/python` directory.
>
>
> Diffs
> -----
>
> support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990
>
>
> Diff: https://reviews.apache.org/r/68560/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>