[GitHub] [flink] RyanSkraba commented on a diff in pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

[GitBox <gi...@apache.org>]

RyanSkraba commented on code in PR #20805:
URL: https://github.com/apache/flink/pull/20805#discussion_r997100160


##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/strategy/RetryOnExceptionStrategy.java:
##########
@@ -37,6 +40,12 @@ public RetryOnExceptionStrategy(
     @Override
     public void handleException(String testName, int attemptIndex, Throwable throwable)

Review Comment:
   Sounds good -- I'll summarize the JUnit behaviour (actually documented in https://junit.org/junit5/docs/5.0.2/api/org/junit/jupiter/api/extension/TestExecutionExceptionHandler.html#handleTestExecutionException-org.junit.jupiter.api.extension.ExtensionContext-java.lang.Throwable-)



##########
flink-test-utils-parent/flink-test-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java:
##########
@@ -80,4 +89,41 @@ void testPassAfterOneFailure() {
             throw new IllegalArgumentException();
         }
     }
+
+    @ParameterizedTest(name = "With {0} retries for {1}")
+    @MethodSource("retryTestProvider")
+    void testRetryFailsWithExpectedExceptionAfterNumberOfRetries(
+            final int numberOfRetries, final Throwable expectedException) {

Review Comment:
   Will do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org