[jira] [Commented] (TAP5-2479) Improvement of SessionApplicationStatePersistenceStrategy

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547652#comment-14547652 ] 

ASF subversion and git services commented on TAP5-2479:
-------------------------------------------------------

Commit 47e20f4c7e3447d2486f6f2921ddbb0de04b70be in tapestry-5's branch refs/heads/master from [~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=47e20f4 ]

TAP5-2479: build the session attribute key only if there is an active session


> Improvement of SessionApplicationStatePersistenceStrategy
> ---------------------------------------------------------
>
>                 Key: TAP5-2479
>                 URL: https://issues.apache.org/jira/browse/TAP5-2479
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Maria Fedotova
>            Priority: Trivial
>              Labels: patch
>         Attachments: TAP5-2479.patch
>
>
> This patch is little improvement in method exists of SessionApplicationStatePersistenceStrategy.
> {code}
> public <T> boolean exists(Class<T> ssoClass)
>     {
>         String key = buildKey(ssoClass);
>         Session session = request.getSession(false);
>         return session != null && session.getAttribute(key) != null;
>     }
> {code}
> We changed the code so that the key is built only when the session is not null.
> This code didn't have effect on time per request, but I think it's useful.
> Thank [~mihasik] for the idea.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)