You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by sk...@apache.org on 2016/11/03 20:13:27 UTC

[6/7] cayenne git commit: [CAY-2129] Modeler reengineer dialog improvements - updated release notes - cleaned up excessive todo's

[CAY-2129] Modeler reengineer dialog improvements
- updated release notes
- cleaned up excessive todo's


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/ba54dc8b
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/ba54dc8b
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/ba54dc8b

Branch: refs/heads/master
Commit: ba54dc8b8bfd7a8427079cb7a793c48833a7371a
Parents: 15d1e53
Author: Nikita Timofeev <st...@gmail.com>
Authored: Wed Nov 2 11:05:09 2016 +0300
Committer: Savva Kolbachev <s....@gmail.com>
Committed: Thu Nov 3 22:55:57 2016 +0300

----------------------------------------------------------------------
 docs/doc/src/main/resources/RELEASE-NOTES.txt                     | 3 ++-
 .../main/java/org/apache/cayenne/modeler/ProjectController.java   | 2 +-
 .../cayenne/modeler/event/DataSourceModificationListener.java     | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cayenne/blob/ba54dc8b/docs/doc/src/main/resources/RELEASE-NOTES.txt
----------------------------------------------------------------------
diff --git a/docs/doc/src/main/resources/RELEASE-NOTES.txt b/docs/doc/src/main/resources/RELEASE-NOTES.txt
index dee079d..b20931a 100644
--- a/docs/doc/src/main/resources/RELEASE-NOTES.txt
+++ b/docs/doc/src/main/resources/RELEASE-NOTES.txt
@@ -36,7 +36,8 @@ CAY-2114 cdbimport: object layer settings are not respected
 CAY-2115 DbLoader - allow loading DataMap without Obj layer
 CAY-2116 Split schema synchronization code in a separate module
 CAY-2118 cdbimport: drop support for the old style of table filtering
-CAY-2132 Adding SybaseSelectTranslator to support TOP/DISTINCT TOP in limited queries 
+CAY-2129 Modeler: reengineer dialog improvements
+CAY-2132 Adding SybaseSelectTranslator to support TOP/DISTINCT TOP in limited queries
 
 Bug Fixes:
 

http://git-wip-us.apache.org/repos/asf/cayenne/blob/ba54dc8b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/ProjectController.java
----------------------------------------------------------------------
diff --git a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/ProjectController.java b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/ProjectController.java
index 12f38c4..f247b50 100644
--- a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/ProjectController.java
+++ b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/ProjectController.java
@@ -1761,7 +1761,7 @@ public class ProjectController extends CayenneController {
                 case MapEvent.ADD:
                     listener.callbackDataSourceAdded(e);
                     break;
-                // TODO Change event not supported for now. Nikita Timofeev
+                // Change event not supported for now
                 // There is no good place to catch data source modification
                 /*case MapEvent.CHANGE:
                     listener.callbackDataSourceChanged(e);

http://git-wip-us.apache.org/repos/asf/cayenne/blob/ba54dc8b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/event/DataSourceModificationListener.java
----------------------------------------------------------------------
diff --git a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/event/DataSourceModificationListener.java b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/event/DataSourceModificationListener.java
index 0b7d0f6..826ccc7 100644
--- a/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/event/DataSourceModificationListener.java
+++ b/modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/event/DataSourceModificationListener.java
@@ -26,7 +26,8 @@ import java.util.EventListener;
  */
 public interface DataSourceModificationListener extends EventListener {
 
-    //TODO change events not supported for now
+    // change events not supported for now
+    // There is no good place to catch data source modification
     //void callbackDataSourceChanged(DataSourceModificationEvent e);
 
     void callbackDataSourceAdded(DataSourceModificationEvent e);