You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/09/10 00:54:11 UTC

Re: Review Request 36127: Removing '.json' extension in files endpoints url

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36127/#review98298
-----------------------------------------------------------

Ship it!


LGTM, but you'll need to rebase this off your other patches so they can easily be committed as a group.


docs/configuration.md (lines 60 - 61)
<https://reviews.apache.org/r/36127/#comment154653>

    You'll have to rebase this after the other patch goes in, or you can mark them as a dependent chain of patches, using RB's "Depends On" field.


- Adam B


On Sept. 9, 2015, 12:58 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36127/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 12:58 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-2984
>     https://issues.apache.org/jira/browse/MESOS-2984
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Removing json extension for HTTP endpoints in files
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2b23d48 
>   src/cli/mesos-cat 73dc63e 
>   src/cli/mesos-tail 256a804 
>   src/files/files.cpp a94a5ee 
>   src/master/flags.cpp 230c1dc 
>   src/slave/flags.cpp b36710d 
>   src/tests/files_tests.cpp 53771cd 
>   src/tests/gc_tests.cpp ec27ac7 
>   src/webui/master/static/browse.html 0904c87 
>   src/webui/master/static/js/controllers.js 3445028 
> 
> Diff: https://reviews.apache.org/r/36127/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>