You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 12:29:04 UTC
[GitHub] [arrow] paleolimbot opened a new pull request, #12836: ARROW-16152: [C++] Typo that causes segfault with unknown functions in Substrait
paleolimbot opened a new pull request, #12836:
URL: https://github.com/apache/arrow/pull/12836
Revised from #12828 with proper JIRA and unit test!
Reprex (after the change in this PR...before this change it segfaults):
``` r
arrow:::do_exec_plan_substrait('
{
"extensionUris": [
{
"extensionUriAnchor": 1
}
],
"extensions": [
{
"extensionFunction": {
"extensionUriReference": 1,
"functionAnchor": 2,
"name": "abs_checked"
}
}
],
"relations": [
{
"rel": {
"project": {
"input": {
"read": {
"baseSchema": {
"names": [
"letter",
"number"
],
"struct": {
"types": [
{
"string": {
}
},
{
"i32": {
}
}
]
}
},
"namedTable": {
"names": [
"named_table_1"
]
}
}
},
"expressions": [
{
"scalarFunction": {
"functionReference": 2,
"args": [
{
"selection": {
"directReference": {
"structField": {
"field": 1
}
}
}
}
],
"outputType": {
}
}
}
]
}
}
}
]
}
')
#> Error: Invalid: Uri was referenced by an extension but was not declared in the ExtensionSet.
#> /Users/deweydunnington/Desktop/rscratch/arrow/cpp/src/arrow/engine/substrait/extension_set.cc:161 set.impl_->CheckHasUri(function_ids[i].uri)
#> /Users/deweydunnington/Desktop/rscratch/arrow/cpp/src/arrow/engine/substrait/serde.cc:66 GetExtensionSetFromPlan(plan)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #12836: ARROW-16152: [C++] Typo that causes segfault with unknown functions in Substrait
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #12836:
URL: https://github.com/apache/arrow/pull/12836#discussion_r846121285
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -724,5 +724,31 @@ TEST(Substrait, ExtensionSetFromPlan) {
EXPECT_EQ(decoded_add_func.name, "add");
}
+TEST(Substrait, ExtensionSetFromPlanMissinFunc) {
Review Comment:
```suggestion
TEST(Substrait, ExtensionSetFromPlanMissingFunc) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12836: ARROW-16152: [C++] Typo that causes segfault with unknown functions in Substrait
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12836:
URL: https://github.com/apache/arrow/pull/12836#issuecomment-1092809704
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12836: ARROW-16152: [C++] Fix segfault with unknown functions in Substrait
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12836: ARROW-16152: [C++] Fix segfault with unknown functions in Substrait
URL: https://github.com/apache/arrow/pull/12836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12836: ARROW-16152: [C++] Typo that causes segfault with unknown functions in Substrait
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12836:
URL: https://github.com/apache/arrow/pull/12836#issuecomment-1092809686
https://issues.apache.org/jira/browse/ARROW-16152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12836: ARROW-16152: [C++] Fix segfault with unknown functions in Substrait
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12836:
URL: https://github.com/apache/arrow/pull/12836#issuecomment-1093691873
Benchmark runs are scheduled for baseline = 0a78b20b681d0e50e117f2e14ca1490c08f16305 and contender = b2853507363e7aa25abc298f20111704e3e24e2f. b2853507363e7aa25abc298f20111704e3e24e2f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/13c6c406fdd847f5b00bd5ea26f3777b...c58e4b023ee1439d8e60a5e7386d740d/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1fd5562b0c474737839660715340b6c1...e749ea06ae7a462799f840ed833ca0f7/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e79762cf5cb8447bba3444800d64509b...92e3f5a0e46b42b59e1f2b5d0d9ed27a/)
[Finished :arrow_down:0.94% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bf395f081ee14dd4b29ab89ca0bc0209...1ca4bff2b38d4351833c1aa36f8a2e03/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/475| `b2853507` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/460| `b2853507` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/461| `b2853507` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/470| `b2853507` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/474| `0a78b20b` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/459| `0a78b20b` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/460| `0a78b20b` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/469| `0a78b20b` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org