You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/28 04:01:23 UTC
Review Request 17443: Added queued and launched tasks to slave stats.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
Bugs: MESOS-775
https://issues.apache.org/jira/browse/MESOS-775
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
Diff: https://reviews.apache.org/r/17443/diff/
Testing
-------
make
Thanks,
Vinod Kone
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/#review32957
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Jan. 27, 2014, 7:02 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17443/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 7:02 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
>
>
> Bugs: MESOS-772
> https://issues.apache.org/jira/browse/MESOS-772
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
>
> Diff: https://reviews.apache.org/r/17443/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 6:06 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
Changes
-------
decided to add "_gauge" suffix after all to make @drob happy.
Bugs: MESOS-772
https://issues.apache.org/jira/browse/MESOS-772
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
Diff: https://reviews.apache.org/r/17443/diff/
Testing
-------
make
Thanks,
Vinod Kone
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/#review32964
-----------------------------------------------------------
Ship it!
src/slave/http.cpp
<https://reviews.apache.org/r/17443/#comment62041>
Same comment as RB 17442. queued_tasks_gauge and launced_tasks_gauge (or active_tasks_gauge, same as whatever gets using in the master).
- David Robinson
On Jan. 28, 2014, 3:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17443/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:02 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
>
>
> Bugs: MESOS-772
> https://issues.apache.org/jira/browse/MESOS-772
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
>
> Diff: https://reviews.apache.org/r/17443/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 28, 2014, 5:08 a.m., Benjamin Hindman wrote:
> > src/slave/http.cpp, line 309
> > <https://reviews.apache.org/r/17443/diff/1/?file=452630#file452630line309>
> >
> > Any reason not to use 'active_tasks' here instead of 'launched_tasks' too?
I went back and forth on the naming. This is my current thinking.
active_tasks on master = (queued_tasks + launched_tasks) on slaves.
calling them launched_tasks on the master seemed a bit confusing because it has a different meaning on the slave.
thoughts?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/#review32953
-----------------------------------------------------------
On Jan. 28, 2014, 3:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17443/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:02 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
>
>
> Bugs: MESOS-772
> https://issues.apache.org/jira/browse/MESOS-772
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
>
> Diff: https://reviews.apache.org/r/17443/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/#review32953
-----------------------------------------------------------
Ship it!
src/slave/http.cpp
<https://reviews.apache.org/r/17443/#comment62016>
Any reason not to use 'active_tasks' here instead of 'launched_tasks' too?
- Benjamin Hindman
On Jan. 28, 2014, 3:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17443/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:02 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
>
>
> Bugs: MESOS-772
> https://issues.apache.org/jira/browse/MESOS-772
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
>
> Diff: https://reviews.apache.org/r/17443/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 3:02 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
Changes
-------
fixed bug id.
Bugs: MESOS-772
https://issues.apache.org/jira/browse/MESOS-772
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
Diff: https://reviews.apache.org/r/17443/diff/
Testing
-------
make
Thanks,
Vinod Kone
Re: Review Request 17443: Added queued and launched tasks to slave stats.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17443/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 3:02 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson, and Niklas Nielsen.
Changes
-------
added 'Depends On'.
Bugs: MESOS-775
https://issues.apache.org/jira/browse/MESOS-775
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/http.cpp c8357e214d2adf2cd712072f58d07b07badb79dc
Diff: https://reviews.apache.org/r/17443/diff/
Testing
-------
make
Thanks,
Vinod Kone